fix: add string decoder as a dependency#522
Merged
mcollina merged 4 commits intonodejs:mainfrom Jul 1, 2023
Merged
Conversation
Member
|
Can you skip those failing jobs in our workflow file? Unfortunately GHA is broken on those old runtimes. |
mcollina
reviewed
Jul 1, 2023
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
There is an exclude attribute that you can add to the matrix instead.
This was referenced Jul 2, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
string_decoderas a dependency as it is imported here.The
string_decoderpackage happened to already be a devDependency ofreadable-streamand hence was not caught as missing by the recently added webpacking tests which have access to the devDependencies. Ideally a test should be added where they do not have access to these.It appears to me that this used to be a dependency but that was removed in 81c5264#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 - it is not clear to me why as a comment was made about this at the time #471 (comment).